Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in transform-trace-data.js #332

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

bhavin192
Copy link
Contributor

Short description of the changes

  • I think there is a typo in the name transfromTraceData this PR fixes that, changes it to transformTraceData

Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #332 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
+ Coverage   83.08%   83.18%   +0.09%     
==========================================
  Files         142      142              
  Lines        3181     3181              
  Branches      654      654              
==========================================
+ Hits         2643     2646       +3     
+ Misses        431      428       -3     
  Partials      107      107
Impacted Files Coverage Δ
...ckages/jaeger-ui/src/model/transform-trace-data.js 84.9% <ø> (ø) ⬆️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 92.59% <0%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd4f809...93de72d. Read the comment docs.

Copy link
Collaborator

@everett980 everett980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ghost ghost assigned tiffon Feb 22, 2019
@ghost ghost added the review label Feb 22, 2019
@tiffon tiffon merged commit c07c41d into jaegertracing:master Feb 22, 2019
@ghost ghost removed the review label Feb 22, 2019
@tiffon
Copy link
Member

tiffon commented Feb 22, 2019

Thanks! 👍

vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Bhavin Gandhi <bhavin7392@gmail.com>
Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants